Add node-level blocker support to ancestor propagation, refactor logic, add tests, bump version - #15
Merged
jeromychu23 merged 2 commits intoMar 5, 2026
Conversation
…with-blocker-condition-cmh6ac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
block_keythat stops ancestor-based target propagation when a blocking event is found with a later target timestamp.Description
has_blocker_on_node_after_targetto detect blocker events on nodes and wire it into traversal termination logic.propagate_target_from_ancestorinto an internalpropagate_target_rowsfunction that operates on&[PyDict]and a thin#[pyfunction]wrapper that accepts a DataFrame and optionalblock_keyparameter.matches_target_key->matches_kv) and adjust calls tocomposite_keyandchoose_candidate_by_planto accept consistent argument types.#[cfg(test)]covering blocker termination, self-node blockers, and parent-node blockers.Cargo.tomlto0.1.3and update the conda reciperecipe/meta.yamlversion to0.1.3while adjusting the buildnumberand test commands to match the new parameter names and signature.Testing
cargo testwhich executed the newpropagate_target_rowsunit tests and they passed.recipe/meta.yamlto call the extendedpropagate_target_from_ancestorsignature; these are included as automated package tests in the recipe.Codex Task